X-Git-Url: http://git.linux-vserver.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=src%2Fvserver-stat.c;h=43e15f372b6594819b55102d452fba3bf9bd9df7;hb=b30eee53f811b1fa1a4a21f84466ab79c9f422c0;hp=101b916984f68cca384a0a023fa12538f0a958ef;hpb=a923f0462d73c4f46c639b8ec4eb86e189047586;p=util-vserver.git diff --git a/src/vserver-stat.c b/src/vserver-stat.c index 101b916..43e15f3 100644 --- a/src/vserver-stat.c +++ b/src/vserver-stat.c @@ -190,6 +190,12 @@ getUptime() return secs*1000 + msecs; } +static inline uint64_t +toMsec(uint64_t v) +{ + return v*1000llu/hertz; +} + static int cmpData(void const *xid_v, void const *map_v) { @@ -306,8 +312,11 @@ registerXidCgroups(struct Vector *vec, struct process_info *process) buf[30]; int fd; ssize_t cgroup_len; - unsigned long long rss; + unsigned long long rss = 0; char *endptr; + size_t len; + uint64_t stime_total, utime_total; + if (vc_virt_stat(xid, &vstat) == -1) { perror("vc_virt_stat()"); @@ -338,14 +347,33 @@ registerXidCgroups(struct Vector *vec, struct process_info *process) cgroup[cgroup_len] = 0; } - snprintf(filename, sizeof(filename), "%s/cgroup/name", vhi_name); + len = strlen(vhi_name); + if ((len + sizeof("/cgroup/name")) >= sizeof(filename)) { + WRITE_MSG(2, "too long context name: "); + WRITE_STR(2, vhi_name); + WRITE_MSG(2, "\n"); + return; + } + strcpy(filename, vhi_name); + strcpy(filename + len, "/cgroup/name"); + if ((fd = open(filename, O_RDONLY)) == -1) { char *dir = strrchr(vhi_name, '/'); if (dir == NULL) { - fprintf(stderr, "invalid context name: %s\n", dir); + WRITE_MSG(2, "invalid context name: "); + WRITE_STR(2, dir); + WRITE_MSG(2, "\n"); return; } - snprintf(cgroup + cgroup_len, sizeof(cgroup) - cgroup_len, "%s", dir); + len = strlen(dir); + if ((len + cgroup_len) >= sizeof(cgroup)) { + WRITE_MSG(2, "cgroup name too long: "); + WRITE_STR(2, dir); + WRITE_MSG(2, "\n"); + return; + } + strcpy(cgroup + cgroup_len, dir); + cgroup_len += len; } else { ssize_t ret; @@ -354,23 +382,62 @@ registerXidCgroups(struct Vector *vec, struct process_info *process) perror("read(cgroup/name)"); return; } + cgroup_len += ret; close(fd); } - snprintf(filename, sizeof(filename), "%s/memory.usage_in_bytes", cgroup); - if ((fd = open(filename, O_RDONLY)) == -1) { - perror("open(memory.usage_in_bytes)"); + if ((cgroup_len + sizeof("/memory.usage_in_bytes")) > sizeof(filename)) { + WRITE_MSG(2, "cgroup name too long: "); + WRITE_STR(2, cgroup); + WRITE_MSG(2, "\n"); return; } - if (read(fd, buf, sizeof(buf)) == -1) { - perror("read(memory.usage_in_bytes)"); - return; + strcpy(filename, cgroup); + strcpy(filename + cgroup_len, "/memory.usage_in_bytes"); + + if ((fd = open(filename, O_RDONLY)) == -1) + perror("open(memory.usage_in_bytes)"); + else { + if (read(fd, buf, sizeof(buf)) == -1) { + perror("read(memory.usage_in_bytes)"); + return; + } + close(fd); + if ((rss = strtoull(buf, &endptr, 0)) == ULLONG_MAX || + (*endptr != '\n' && *endptr != '\0')) { + perror("strtoull(memory.usage_in_bytes)"); + return; + } } - close(fd); - if ((rss = strtoull(buf, &endptr, 0)) == ULLONG_MAX || - (*endptr != '\n' && *endptr != '\0')) { - perror("strtoull(memory.usage_in_bytes)"); - return; + + strcpy(filename, cgroup); + strcpy(filename + cgroup_len, "/cpuacct.stat"); + + if ((fd = open(filename, O_RDONLY)) == -1) { + utime_total = 0; + stime_total = 0; + // XXX: arbitrary CPU limit. + for (cpu = 0; cpu < 1024; cpu++) { + sched.cpu_id = cpu; + sched.bucket_id = 0; + if (vc_sched_info(xid, &sched) == -1) + break; + + utime_total += sched.user_msec; + stime_total += sched.sys_msec; + } + } + else { + if (read(fd, buf, sizeof(buf)) == -1) { + perror("read(cpuacct.stat)"); + return; + } + close(fd); + + if (sscanf(buf, "user %llu\nsystem %llu\n", &utime_total, &stime_total) != 2) { + perror("sscanf(cpuacct.stat)"); + return; + } } res = Vector_insert(vec, &xid, cmpData); @@ -380,29 +447,13 @@ registerXidCgroups(struct Vector *vec, struct process_info *process) res->VmRSS_total = rss / 4096; res->start_time_oldest= getUptime() - vstat.uptime/1000000; - res->utime_total = 0; - res->stime_total = 0; - // XXX: arbitrary CPU limit. - for (cpu = 0; cpu < 1024; cpu++) { - sched.cpu_id = cpu; - sched.bucket_id = 0; - if (vc_sched_info(xid, &sched) == -1) - break; - - res->utime_total += sched.user_msec; - res->stime_total += sched.sys_msec; - } + res->utime_total = toMsec(utime_total); + res->stime_total = toMsec(stime_total); } res->VmSize_total += process->VmSize; } -static inline uint64_t -toMsec(uint64_t v) -{ - return v*1000llu/hertz; -} - // shamelessly stolen from procps... static unsigned long @@ -733,7 +784,7 @@ int main(int argc, char **argv) Vector_init(&xid_data, sizeof(struct XidData)); - if (vc_isSupported(vcFEATURE_VSTAT) && !vc_isSupported(vcFEATURE_MEMCG)) { + if (vc_isSupported(vcFEATURE_VSTAT)) { unsigned long xid; Echdir(PROC_VIRT_DIR_NAME); proc_dir = Eopendir(".");